Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon plugin: support HTTP Found response and discard wrong stored cache #809

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@dai-vdr
Copy link
Contributor

commented Aug 15, 2019

amazonプラグインにて

undefined method `has_item?' for nil:NilClass (NoMethodError)

(plugin/amazon.rb):305:in `rescue in amazon_get'
(plugin/amazon.rb):279:in `amazon_get'
(plugin/amazon.rb):387:in `isbn_image'

というエラーが出るため調べたところ、XMLであるはずのキャッシュが true という文字列のみになっていました。

HTTP Redirection 以外に HTTP Found でもリダイレクトしていたためそれを追加、また既に間違って true をキャッシュしていた場合は取得し直すようにしました。

@tdtds tdtds self-assigned this Aug 15, 2019

@tdtds tdtds self-requested a review Aug 15, 2019

@tdtds tdtds added the bug label Aug 15, 2019

@tdtds tdtds added this to In progress in 5.0.15リリース via automation Aug 15, 2019

@tdtds

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

ありがとうございます。なるほど、良さそうです。とりこみますね。

@tdtds tdtds merged commit fdbbf1e into tdiary:master Aug 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix_amazon_wrong_stored_cache at 83.589%
Details

5.0.15リリース automation moved this from In progress to Done Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.