Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_PHYLUM_NOTEMPTY #218

Closed
Tasilee opened this issue Jan 28, 2024 · 2 comments
Closed

TG2-VALIDATION_PHYLUM_NOTEMPTY #218

Tasilee opened this issue Jan 28, 2024 · 2 comments
Labels
Completeness NAME Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@Tasilee
Copy link
Collaborator

Tasilee commented Jan 28, 2024

TestField Value
GUID 19bbd107-6b14-4c82-8d3e-f7a2a67df309
Label VALIDATION_PHYLUM_NOTEMPTY
Description Is there a value in dwc:phylum?
TestType Validation
Darwin Core Class Taxon
Information Elements ActedUpon dwc:phylum
Information Elements Consulted dwc:taxonRank
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:phylum is EMPTY and dwc:taxonRank contains a value that is not interpretable as a taxon rank; COMPLIANT if dwc:phylum is not EMPTY, or dwc:phylum is EMPTY and the value in dwc:taxonRank is higher than phylum; otherwise NOT_COMPLIANT.
Data Quality Dimension Completeness
Term-Actions PHYLUM_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2024-07-17
Examples [dwc:phylum="phylum": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:phylum is not EMPTY"]
[dwc:phylum="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:phylum is EMPTY"]
Source TG2
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes The definition of dwc:phylum includes both phylum and division. This bdq:Supplementary test is not regarded as CORE (cf. bdq:CORE) because of one or more of the reasons: not being widely applicable; not informative; not straightforward to implement or likely to return a high percentage of either bdq:COMPLIANT or bdq:NOT_COMPLIANT results (cf bdq:Response.result). A Supplementary test may be implemented as CORE when a suitable use case exists.
@Tasilee Tasilee added TG2 NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Completeness Validation labels Jan 28, 2024
@Tasilee Tasilee closed this as completed Feb 4, 2024
@Tasilee
Copy link
Collaborator Author

Tasilee commented Jun 3, 2024

Changed Expected Response from

COMPLIANT if dwc:ohtlum is not EMPTY; otherwise NOT_COMPLIANT |

to

INTERNAL_PREREQUISITES_NOT_MET if dwc:phylum is EMPTY or dwc:taxonRank contains a value that is not interpretable as a taxon rank; COMPLIANT if the value in dwc:taxonRank is higher than phylum or if dwc:phylum is not EMPTY; otherwise NOT_COMPLIANT.

@Tasilee
Copy link
Collaborator Author

Tasilee commented Jun 4, 2024

Changed Expected Response from

INTERNAL_PREREQUISITES_NOT_MET if dwc:phylum is EMPTY or dwc:taxonRank contains a value that is not interpretable as a taxon rank; COMPLIANT if the value in dwc:taxonRank is higher than phylum or if dwc:phylum is not EMPTY; otherwise NOT_COMPLIANT.

to

INTERNAL_PREREQUISITES_NOT_MET if dwc:phylum is EMPTY and dwc:taxonRank contains a value that is not interpretable as a taxon rank; COMPLIANT if dwc:phylum is not EMPTY, or dwc:phylum is EMPTY and the value in dwc:taxonRank is higher than phylum; otherwise NOT_COMPLIANT.

chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 17, 2024
…tdwg/bdq#215 tdwg/bdq#217 and tdwg/bdq#218 not empty tests for higher ranks below kingdom, including utility method to evaluate ordering of pairs of rank values and unit tests.
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 18, 2024
…tdwg/bdq#220 tdwg/bdq#219 and tdwg/bdq#218 more not empty tests, including bugfix in utility method to evaluate ordering of pairs of rank values, bugfixes to multiple tests that check a higher classification term and the rank, and unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completeness NAME Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
No open projects
Development

No branches or pull requests

1 participant