Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_INFRASPECIFICEPITHET_NOTEMPTY #219

Closed
Tasilee opened this issue Jan 28, 2024 · 4 comments
Closed

TG2-VALIDATION_INFRASPECIFICEPITHET_NOTEMPTY #219

Tasilee opened this issue Jan 28, 2024 · 4 comments
Labels
Completeness NAME Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@Tasilee
Copy link
Collaborator

Tasilee commented Jan 28, 2024

TestField Value
GUID 77c6fde2-c3ca-4ad3-b2f2-3b81bba9a673
Label VALIDATION_INFRASPECIFICEPITHET_NOTEMPTY
Description Is there a value in dwc:infraspecificEpithet?
TestType Validation
Darwin Core Class dwc:Taxon
Information Elements ActedUpon dwc:infraspecificEpithet
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:infraspecificEpithet is EMPTY and dwc:taxonRank contains a value that is not interpretable as a taxon rank; COMPLIANT if dwc:infraspecificEpithet is NOT EMPTY, or dwc:infraspecificEpithet is EMPTY and the value in dwc:taxonRank is higher than infraspecific epithet; otherwise NOT_COMPLIANT.
Data Quality Dimension Completeness
Term-Actions INFRASPECIFICEPITHET_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2024-06-05
Examples [dwc:infraspecificEpithet="noidea": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:infraspecificEpithet is not EMPTY"]
[dwc:infraspecificEpithet="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:infraspecificEpithet is EMPTY"]
Source TG2
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes This bdq:Supplementary test is not regarded as CORE (cf. bdq:CORE) because of one or more of the reasons: not being widely applicable; not informative; not straightforward to implement or likely to return a high percentage of either bdq:COMPLIANT or bdq:NOT_COMPLIANT results (cf bdq:Response.result). A Supplementary test may be implemented as CORE when a suitable use case exists.
@Tasilee Tasilee added TG2 NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Completeness Validation labels Jan 28, 2024
@Tasilee Tasilee closed this as completed Feb 4, 2024
@chicoreus
Copy link
Collaborator

This test very much calls out for examination of dwc:taxonRank as noted in #214. Any occurrences identified to the rank of species or above will correctly have dwc:infraspecificEpithet as empty, similarly for Taxon records in checklist data. This test, as is, will call out very large numbers of correct records as unfit for use. All of the tests listed in #214 suffer from this problem, but it is most egregious here and in the related but more complex problem in #265.

@chicoreus chicoreus reopened this Feb 15, 2024
@Tasilee
Copy link
Collaborator Author

Tasilee commented Feb 19, 2024

@chicoreus - I agree, with 1.5% GBIF records and 2.3% ALA records having NOTEMPTY, and the argument for the complexity in having to include other terms for utility suggests Immature/Incomplete?

Is the concept of the test informative (enough) either way (=Supplementary)? Is there a rational use case?

What do others think?

@ArthurChapman
Copy link
Collaborator

Agree with @chicoreus - I guess it still NEEDS WORK and is Immature/Incomplete as is.

@Tasilee Tasilee added Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca and removed NEEDS WORK Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 20, 2024
@Tasilee
Copy link
Collaborator Author

Tasilee commented Jun 4, 2024

Changed Expected Response from

COMPLIANT if dwc:infraspecificEpithet is not EMPTY; otherwise NOT_COMPLIANT

to

INTERNAL_PREREQUISITES_NOT_MET if dwc:infraspecificEpithet is EMPTY and dwc:taxonRank contains a value that is not interpretable as a taxon rank; COMPLIANT if dwc:infraspecificEpithet is not EMPTY, or dwc:infraspecificEpithet is EMPTY and the value in dwc:taxonRank is higher than infraspecific epithet; otherwise NOT_COMPLIANT.

@Tasilee Tasilee added Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. and removed Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca labels Jun 4, 2024
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 18, 2024
…tdwg/bdq#220 tdwg/bdq#219 and tdwg/bdq#218 more not empty tests, including bugfix in utility method to evaluate ordering of pairs of rank values, bugfixes to multiple tests that check a higher classification term and the rank, and unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completeness NAME Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
No open projects
Development

No branches or pull requests

3 participants