-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_GEOREFERENCEDDATE_NOTEMPTY #256
Comments
Problematic as phrased, Will improperly fail for any data that lacks a georeference where the dwc:georefencedDate is correctly empty. Needs dwc:decimalLatitude as an information element consulted. Propose specification: COMPLIANT if dwc:decimalLatitude is EMPTY or dwc:georeferencedDate is not EMPTY; otherwise NOT_COMPLIANT |
Principle: A test should test one thing. As phrased "COMPLIANT if dwc:georeferencedDate is not EMPTY; otherwise NOT_COMPLIANT" it is testing both the presence of a georeference and the presence of this element of georeference metadata. Properly phrased, it should only assess the presence of georeference metadata if there is a georeference to have metadata. |
I agree @chicoreus that a test should test one thing, or more accurately, one concept (as many tests apply to multiple Information Elements). Here, a COMPLIANT response may have value, but I agree that a NOT_COMPLAINT response doesn't, without the context of a georeference. This IS a reason for this test to be not CORE and this reason (as I mentioned earlier) should be in the Notes, and this test should have a DO NOT IMPLEMENT tag. |
I have changed the Notes to "A COMPLIANT response on this test may have some quality value in some use cases, but a NOT_COMPLAINT response doesn't, without the context of a georeference." |
@Tasilee I don't think so. We can actually fix this so that it is useful, still supplementary, but useful. This is one of a large number of tests, some of which are CORE where we do have to work out the appropriate way to identify when the data values should correctly be empty. |
We can fix this with COMPLIANT if dwc:decimalLatitude is EMPTY or dwc:georeferencedDate is not EMPTY; otherwise NOT_COMPLIANT as proposed above. |
This is a general pattern for a number of tests of metadata terms that depend on the presence of other terms. |
@chicoreus - I'd be happy to go along with that. I think, though, that anyone attempting to implement this or make it a CORE test at a later date would need to look at all the implications. Not something we want to spend time on now. |
Changing the Expected Response to COMPLIANT if dwc:decimalLatitude is EMPTY or dwc:georeferencedDate is not EMPTY; otherwise NOT_COMPLIANT doesn't make sense as the response will be COMPLIANT if dwc:decimalLatitude is EMPTY regardless of the status of dwc:georeferencedDate. We are attributing 'quality' via a term not the focus of the test. This raises the general concept that at least some NOTEMPTY tests are potential ISSUEs rather than VALIDATIONs. Maybe POTENTIAL_ISSUE if dwc:georeferencedDate is EMPTY and dwc:decimalLatitude is not EMPTY; otherwise NOT_ISSUE ? |
This is the same test as #227. Closing as Duplicate |
The text was updated successfully, but these errors were encountered: