Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Editor breaks Gallery #4

Closed
hasinasi opened this issue Feb 10, 2018 · 6 comments
Closed

Link Editor breaks Gallery #4

hasinasi opened this issue Feb 10, 2018 · 6 comments
Labels

Comments

@hasinasi
Copy link

As soon as I enable Link Editor 1.0.3 in nc 13 gallery mode gets severely broken. Clicking on the icon showing the 4 tiles (to switch into thumbnail mode), nothing happens; the screen below the button just stays white. Similarly, the icon/button designed to be bringing you back into "normal" mode (smaller icons on the left with file information) just does nothing. The only way to get back is to click the main icon of the "files" app, bringing you back to the root folder.
Tried it on 2 machines, and this happens in 100% of the cases, and it goes immediately away, as soon as the Link Editor app is disabled. Otherwise the app works as expected.

@SimJoSt
Copy link

SimJoSt commented Feb 10, 2018

I observed the same exact behavior. It's a pity, as I would like to use this app, but the overwhelming amount of our users will prefer the gallery app :'(

@te-online
Copy link
Owner

Thanks for your reports! I'll fix this in the next version. I knew there was some kind of collision I hadn't fixed yet and this is the exact spot.

@te-online
Copy link
Owner

I could resolve an issue where the JavaScript would get loaded in wrong places and cause fatal JavaScript errors, resulting in side-effects on other scripts. Can you see if the problem still persists with version 1.0.4, as soon as the appstore offers it to you?

@hasinasi
Copy link
Author

hasinasi commented Mar 7, 2018

I just tested it, and as far as I can tell, the issue is fixed now! Thanks so much for looking into this and for fixing it!

@SimJoSt
Copy link

SimJoSt commented Mar 7, 2018

Same here. Everything works as expected.
Was surprised for a second, that I cannot edit on a left click, but have to go through the menu of the file.

@te-online
Copy link
Owner

Was surprised for a second, that I cannot edit on a left click, but have to go through the menu of the file.

@SimJoSt Yes, this is a known UX-problem. I'll try to fix this in the next release. See #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants