Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export csv file with special character table name abort #600

Merged
merged 3 commits into from
May 11, 2024
Merged

fix: export csv file with special character table name abort #600

merged 3 commits into from
May 11, 2024

Conversation

caoxing9
Copy link
Contributor

@caoxing9 caoxing9 commented May 11, 2024 •
edited
Loading

relative issue: #598

@caoxing9 caoxing9 linked an issue May 11, 2024 that may be closed by this pull request
when export csv if table name contains china charactor ,it will fail #598
Closed
@coveralls
Copy link
Collaborator

coveralls commented May 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9041758775

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.6%) to 83.83%
Totals Coverage Status
Change from base Build 9013477501: 63.6%
Covered Lines: 26237
Relevant Lines: 31298
💛 - Coveralls

@caoxing9 caoxing9 merged commit 52269a6 into develop May 11, 2024
6 checks passed
@caoxing9 caoxing9 deleted the fix/export-character-error branch May 11, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when export csv if table name contains china charactor ,it will fail
3 participants
@caoxing9 @coveralls @tea-artist