Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table list permission #603

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: table list permission #603

merged 1 commit into from
May 13, 2024

Conversation

boris-w
Copy link
Contributor

@boris-w boris-w commented May 13, 2024

No description provided.

@boris-w boris-w requested a review from tea-artist May 13, 2024 11:26
@coveralls
Copy link
Collaborator

coveralls commented May 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9062052521

Details

  • 43 of 101 (42.57%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+63.1%) to 83.371%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/base/base.controller.ts 3 7 42.86%
apps/nestjs-backend/src/features/table/table.service.ts 0 5 0.0%
apps/nestjs-backend/src/features/base/base.service.ts 10 17 58.82%
apps/nestjs-backend/src/features/table/table-permission.service.ts 11 53 20.75%
Totals Coverage Status
Change from base Build 9059340219: 63.1%
Covered Lines: 26396
Relevant Lines: 31661
💛 - Coveralls

tea-artist
tea-artist approved these changes May 13, 2024
View reviewed changes
packages/core/src/models/notification/action-trigger.schema.ts
@@ -5,6 +5,7 @@ export const actionTriggerBufferValue = z.object({
setRecord: z.string().array().optional(),
deleteRecord: z.string().array().optional(),

addField: z.string().array().optional(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if deleteField needs to be considered?

@tea-artist tea-artist merged commit b32d7cc into develop May 13, 2024
8 checks passed
@tea-artist tea-artist deleted the fix/table-list-permission branch May 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tea-artist tea-artist tea-artist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boris-w @coveralls @tea-artist