Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: select field rendering #620

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

Sky-FE
Copy link
Contributor

@Sky-FE Sky-FE commented May 23, 2024

No description provided.

@Sky-FE Sky-FE requested a review from tea-artist May 23, 2024 15:43

export class SingleSelectField extends Mixin(SingleSelectFieldCore, Field) {}
export class SingleSelectField extends Mixin(SingleSelectFieldCore, Field) {
private _choiceMap: Record<string, ISelectFieldDisplayChoice> = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to repeat the code, create a new class SelectFieldSdk and put it in mixin

@coveralls
Copy link
Collaborator

coveralls commented May 24, 2024

Pull Request Test Coverage Report for Build 9219031367

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 62 of 361 (17.17%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 18.967%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nextjs-app/src/features/app/components/field-setting/FieldSetting.tsx 0 1 0.0%
packages/sdk/src/components/editor/select/components/index.ts 0 1 0.0%
packages/sdk/src/components/grid/components/editor/EditorContainer.tsx 0 1 0.0%
packages/sdk/src/components/grid/hooks/useColumnFreeze.ts 0 1 0.0%
packages/sdk/src/model/field/multiple-select.field.ts 0 2 0.0%
packages/sdk/src/model/field/single-select.field.ts 0 2 0.0%
packages/sdk/src/components/grid-enhancements/hooks/use-grid-columns.tsx 0 3 0.0%
packages/sdk/src/components/grid-enhancements/hooks/use-grid-group-collection.ts 0 3 0.0%
packages/sdk/src/components/grid/renderers/cell-renderer/selectCellRenderer.ts 0 4 0.0%
apps/nextjs-app/src/features/app/components/field-setting/FieldEditor.tsx 47 52 90.38%
Totals Coverage Status
Change from base Build 9203268202: 0.2%
Covered Lines: 13851
Relevant Lines: 73028

💛 - Coveralls

@tea-artist tea-artist merged commit a5ec82c into develop May 24, 2024
5 checks passed
@tea-artist tea-artist deleted the perf/select-field-rendering branch May 24, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants