Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import relative #810

Merged
merged 12 commits into from
Aug 23, 2024
Merged

fix: import relative #810

merged 12 commits into from
Aug 23, 2024

Conversation

caoxing9
Copy link
Contributor

@caoxing9 caoxing9 commented Aug 9, 2024

feat

  • support gird view export
  • add import status

fix

  • timezone validate
  • import empty file preset default field
  • lacking error notification when import aborted

perf

  • realtime update record when importing
  • speed up inplace import by discarding ops

@caoxing9 caoxing9 linked an issue Aug 9, 2024 that may be closed by this pull request
@caoxing9 caoxing9 marked this pull request as draft August 9, 2024 10:30
@coveralls
Copy link
Collaborator

coveralls commented Aug 9, 2024

Pull Request Test Coverage Report for Build 10523150885

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 130 of 149 (87.25%) changed or added relevant lines in 6 files are covered.
  • 36 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 83.355%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/nestjs-backend/src/features/import/open-api/import.class.ts 0 1 0.0%
apps/nestjs-backend/src/features/export/open-api/export-open-api.service.ts 29 34 85.29%
apps/nestjs-backend/src/features/import/open-api/import-open-api.service.ts 90 103 87.38%
Files with Coverage Reduction New Missed Lines %
apps/nestjs-backend/src/features/import/open-api/import-open-api.service.ts 2 87.61%
apps/nestjs-backend/src/features/calculation/reference.service.ts 2 92.68%
apps/nestjs-backend/src/features/field/open-api/field-open-api.service.ts 10 63.82%
apps/nestjs-backend/src/features/field/field-calculate/field-converting.service.ts 22 84.22%
Totals Coverage Status
Change from base Build 10466984753: 0.3%
Covered Lines: 30804
Relevant Lines: 36955

💛 - Coveralls

@caoxing9 caoxing9 linked an issue Aug 9, 2024 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

@caoxing9 caoxing9 linked an issue Aug 21, 2024 that may be closed by this pull request
@caoxing9 caoxing9 marked this pull request as ready for review August 22, 2024 13:50
@caoxing9 caoxing9 merged commit c2585c8 into develop Aug 23, 2024
7 checks passed
@caoxing9 caoxing9 deleted the fix/import-relative branch August 23, 2024 09:28
AliceLanniste pushed a commit to AliceLanniste/teable that referenced this pull request Sep 1, 2024
* fix: import empty table should set default field

* feat: compatible csv encoding when import

* fix: compatible more timezone

* feat: support grid view export

* fix: import abort message missing in notifycation

* feat: update rowcount realtime when importing

* chore: delete useless code

* feat: remove inplace import ops save

* feat: add importing status

* feat: update sdk i18n description about import

* chore: update tips before import

* perf: optimize big file import process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants