feat: integrating plugins and scripts #92
Conversation
mitosagi
force-pushed
the
refactor-plugin-script
branch
from
8ff494e
to
00e70af
Compare
|
In relation to this PR, I would like to call the plugin and the script together as a package, what do you think? |
|
I think calling it a package in the code or xml is a good idea. The exception is that I think many people who don't do programming are not familiar with calling a zip file a package, so I'd like to call it plugin&script on the UI. Do you think this is a good way to go? |
BREAKING CHANGE: Data about the scripts is deleted. fix #70
|
Yes, I think so too. Also, after all, apm is dealing with scripts as well as plugins, so I'm starting to think that the name of the application should be AviUtl Package Manager. (As in #90) |
|
I prefer the "plugin manager", which is easier to understand the features. But the "package manager" is also good. |
|
I see... |
BREAKING CHANGE: changing the file name and tag name of the xml file
mitosagi
force-pushed
the
refactor-plugin-script
branch
from
7ae64e8
to
e8c50fe
Compare
|
I replaced "plugin" with "package" in the code. I've changed the XML tag names, so I' ll send a PR to apm-data as well after the merge. |
hal-shu-sato
added
Feedback: enhancement
|
Certainly, it would be better to use a name that covers the function, so that we won't regret it later. |
|
Certainly... |
src/package/package.js
Outdated
| @@ -168,6 +186,7 @@ module.exports = { | |||
| .filter((i) => i.isFile() && regex.test(i.name)) | |||
| .map((i) => i.name); | |||
| return readdir(instPath).concat( | |||
| readdir(path.join(instPath, 'packages')).map((i) => 'packages/' + i), | |||
There was a problem hiding this comment.
There is a bug.
I don't have enough time to suggest all the fixes, so I apologize for the messy suggestions.
| readdir(path.join(instPath, 'packages')).map((i) => 'packages/' + i), | |
| readdir(path.join(instPath, 'plugins')).map((i) => 'plugins/' + i), |
There was a problem hiding this comment.
Oh, I certainly didn't check there.
I checked the other strings, but I think the only part I need to change is where you suggested.
Description
Remove code related to the script. This will require integration of
plugins_list.xmlwithscripts_list.xml.BREAKING CHANGE
plugins_list.xmltopackages_list.xml. The new tag names are<packages>and<package>.Related Issue
fix #70
Motivation and Context
How Has This Been Tested?
plugins_list.xmlpackages_list.xmlattached below, you can install and uninstall the plugin and script without any problems.plugins_list.zippackages_list.zip
Screenshots (if appropriate):
Types of changes
Checklist: