Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change to use the path of the file specified in the archive in the data file #99

Merged
merged 2 commits into from
Sep 7, 2021
Merged

feat: change to use the path of the file specified in the archive in the data file #99

merged 2 commits into from
Sep 7, 2021

Conversation

hal-shu-sato
Copy link
Member

@hal-shu-sato hal-shu-sato commented Sep 7, 2021 •
edited
Loading

Description

Changes to use the path of the file specified in the archive in the data file.
This reduces the number of errors.

Related Issue

Closes #52

Motivation and Context

Reference #52

How Has This Been Tested?

OS: Windows 10 Home
Version: 21H1

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hal-shu-sato hal-shu-sato added Feedback: enhancement New feature or request Type: improvement Improvements to program labels Sep 7, 2021
@hal-shu-sato hal-shu-sato self-assigned this Sep 7, 2021
@hal-shu-sato hal-shu-sato added the Type: new feature Suggesting new features label Sep 7, 2021
@hal-shu-sato hal-shu-sato mentioned this pull request Sep 7, 2021
Merged
@hal-shu-sato hal-shu-sato merged commit 0669b39 into main Sep 7, 2021
@hal-shu-sato hal-shu-sato deleted the hal-shu-sato/issue52 branch September 7, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hal-shu-sato hal-shu-sato

Labels
Feedback: enhancement New feature or request Type: improvement Improvements to program Type: new feature Suggesting new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify the path of the file in the archive in the data file
1 participant
@hal-shu-sato