This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
テスト通した #291
Merged
テスト通した #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxfie1d
commented
Jul 2, 2020
| page: anyNamed('page'), | ||
| )).thenAnswer((_) => Future.value([pin])); | ||
| bloc | ||
| ..add(const LoadBoardList()) |
There was a problem hiding this comment.
CreatePinイベントがDefaultStateでないと機能しないため、先にLoadBoardListイベントを発行してInitialState -> DefaultStateに遷移するようにしてます。
| @@ -106,7 +106,7 @@ class EditPin extends Equatable { | |||
| title: json['title'] as String, | |||
| description: json['description'] as String, | |||
| isPrivate: json['isPrivate'] as bool, | |||
| tags: (json['tags'] as String)?.toTagList(), | |||
| tags: (json['tagString'] as String)?.toTagList(), | |||
There was a problem hiding this comment.
as String ということは tags ではなく tagString が正しいと思い、修正しました。
Codecov Report
@@ Coverage Diff @@
## develop #291 +/- ##
===========================================
- Coverage 76.75% 76.48% -0.27%
===========================================
Files 29 29
Lines 714 791 +77
===========================================
+ Hits 548 605 +57
- Misses 166 186 +20
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #290
テスト通るようにしたが、直し方が合っているか一応確認してほしいです。