This repository has been archived by the owner on Apr 7, 2018. It is now read-only.
Create dockers #23
Merged
Create dockers #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We CAN fetch all dependencies. We CANNOT YET do anything with them. Matches keywords to Docker repos TODO: return anything. Oops! But the match occurs.
dependencies. Promise actually returns something! Calloo callay! Clean up packageParser - Remove extra console.logs - Make comments more clear & useful - Add a comment on how to use the module Initial commit - Update .gitignore to ignore - Dockerfile - Omnigraffle files - writeDockerfile pulls from package-parser (team-jwt#20) Rough out how we'll make Dockerfiles - Create methods - Figure out inputs/outputs/how stuff works Can check for, make Docker files - Figures out recipe (official repos only) - Writes recipe TODO: hook it all together Part of team-jwt#20 Write docker files - Receive the data from the parsed package - Figure out what dockerfiles to write - Write them - RETURN THE WRONG THING d'oh!
- Now with correct output Close team-jwt#20
Whoops, I created a merge conflict by replacing two lets with consts Thus the last rebase couldn't be automatically merged on pull So I merged here I apologize for making the commit timeline dirty.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20