Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute/unmute conference participant in UI #36

Merged
merged 12 commits into from
Oct 5, 2020
Merged

Mute/unmute conference participant in UI #36

merged 12 commits into from
Oct 5, 2020

Conversation

SuaYoo
Copy link
Contributor

@SuaYoo SuaYoo commented Oct 2, 2020 •
edited
Loading

Mute and unmutes conference participants from browser app.

It's not the prettiest UI, but we have a card in TODO for a UI refresh.

✋ Manual testing

It's much easier to test this with two people, happy to test with you.

  1. Run call-center app and log in
  2. Call your call center phone number and answer. Add a test buddy's phone number to the conference (this will be very confusing to test if you try to do it yourself.) Verify you see the mute button next to participant's name/number
  3. Mute and unmute your conference participant. Verify that audio mute/unmutes

🦊 Browser testing

Desktop

  • Edge
  • Chrome
  • Firefox
  • Safari

Mobile

  • Chrome (Android)
  • Safari (iOS)

📸 Screenshots

Screen Shot 2020-10-02 at 3 10 52 PM

Screen Shot 2020-10-02 at 3 10 59 PM

@SuaYoo SuaYoo force-pushed the WEBRTC-170_Mute_call_center_participant_UI branch from e33d018 to 81f6ea2 Compare October 2, 2020 20:33
@SuaYoo SuaYoo changed the base branch from main to WEBRTC-170_Mute_call_center_participant October 2, 2020 20:34
@SuaYoo SuaYoo mentioned this pull request Oct 2, 2020
Merged
@SuaYoo SuaYoo changed the title Add button to mute/unmute conference participant Mute/unmute conference participant in UI Oct 2, 2020
@SuaYoo SuaYoo marked this pull request as ready for review October 2, 2020 22:14
Base automatically changed from WEBRTC-170_Mute_call_center_participant to main October 5, 2020 18:32
@DeividVeloso DeividVeloso merged commit 91092a2 into main Oct 5, 2020
@DeividVeloso DeividVeloso deleted the WEBRTC-170_Mute_call_center_participant_UI branch October 5, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeividVeloso DeividVeloso DeividVeloso approved these changes

@hugooliveirad hugooliveirad Awaiting requested review from hugooliveirad

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuaYoo @DeividVeloso