Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call not minimizing on back button on mobile #76

Closed
krida2000 opened this issue Aug 16, 2022 · 0 comments · Fixed by #80
Closed

Call not minimizing on back button on mobile #76

krida2000 opened this issue Aug 16, 2022 · 0 comments · Fixed by #80
Assignees
@krida2000
Labels
bug Bugs and incorrectness problems enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes platform::android Specific to Android platform
Milestone
0.1.0-alpha.6

Comments

@krida2000
Copy link
Contributor

krida2000 commented Aug 16, 2022 •
edited
Loading

Summary

На мобильных устройствах, если звонок открыт на весь экран, при нажатии кнопки назад звонок не сворачивается.

Steps to reproduce

  1. Начать звонок на мобильном устойстве.
  2. Нажать кнопку назад.
  3. Увидеть что звонок не свернулся.

What is the current bug behavior?

Звонок не сворачивается.

What is the expected correct behavior?

Звонок сворачивается.

Possible fixes

Смотреть нужно в сторону колбэка Navigator.onPopPage (внутри роутера домашней страницы, внешняя дёргается, когда нечего дёргать во внутренней, но учитывать нужно обе) - он дёргается, когда кнопка назад нажимается. Нужно будет в RouterState добавить список колбэков, которые будут дёргаться при onPopPage в каком-нибудь порядке добавления, например. И если кто-то из этих колбэков кинет нам false, то возвращаем false в onPopPage (например, колбэк звонка тогда будет минимизировать себя)
@krida2000 krida2000 added bug Bugs and incorrectness problems enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Aug 16, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.6 milestone Aug 16, 2022
@krida2000 krida2000 self-assigned this Aug 16, 2022
@krida2000 krida2000 mentioned this issue Aug 17, 2022
Merged
14 tasks
@SleepySquash SleepySquash added the platform::android Specific to Android platform label Aug 18, 2022
SleepySquash pushed a commit that referenced this issue Aug 18, 2022
@krida2000
Fix back button not minimizing Call on Android (#80, #76)
7ab4921 
Additionally:
- fix errors in mobile `Call`s ignoring `SafeArea`
github-actions bot added a commit that referenced this issue Aug 18, 2022
@github-actions
Fix back button not minimizing Call on Android (#80, #76)
1ff808a 
Additionally:
- fix errors in mobile `Call`s ignoring `SafeArea` 7ab4921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krida2000 krida2000

Labels
bug Bugs and incorrectness problems enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes platform::android Specific to Android platform
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging a pull request may close this issue.

Add mobile call minimizing on back button (#76) team113/messenger
2 participants
@SleepySquash @krida2000