-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement push notifications deleting #1038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleepySquash
added
enhancement
Improvement of existing features or bugfix
k::refactor
Refactor changes of existing code
labels
Jun 13, 2024
SleepySquash
commented
Jun 28, 2024
14 tasks
FCM
|
github-actions bot
added a commit
that referenced
this pull request
Jul 26, 2024
…g push notifications (#1038) - impl and use Notification Service Extension on iOS to send `Query.chatItems` query - refactor `handlePushNotification` to send `Query.chatItems` when receiving push notification on Android - refactor native `connect()` for `drift` to use `IosUtils.getSharedDirectory()` for iOS - refactor `NotificationService` to send `Query.chatItems` when receiving foreground notifications Additionally: - bootstrap `AndroidUtils.cancelNotification()` for canceling displayed notifications on Android - bootstrap `IosUtils.cancelNotification()` for canceling displayed notifications on iOS - refactor Firebase Service Worker on web to support displayed notifications canceling 9324909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
k::refactor
Refactor changes of existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
Push notifications can be received from the FCM, however they can be replaced but cannot be deleted.
Solution
This PR allows the notifications to be deleted when empty
notification
body is being sent.Checklist
k::
labels applied