-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep GraphQL subscriptions active only on a single tab in Web (#1047) #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleepySquash
added
enhancement
Improvement of existing features or bugfix
k::refactor
Refactor changes of existing code
labels
Jul 1, 2024
SleepySquash
commented
Jul 3, 2024
UPD. Moved to #1060 The bugs that should be addressed:
|
2 tasks
FCM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existing features or bugfix
k::refactor
Refactor changes of existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1047
Synopsis
Solution
The current idea is to use
WebUtils.protect
, so that tabs don't invoke subscriptions at the same time at all. After some testing the idea seems to be working. The bugs left to fix:Moved to RefactorChatItem
s don't get real-time updates fromdrift
, user must re-enter the chat for new messages fromdrift
to appear. This is because SQL query executes only after re-entering the chat. Should refactor that to be awatch
.RxChat.mesages
pagination towatch()
changes fromdrift
#1060Checklist
k::
labels applied