Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and redesign ContextMenu (#132) #147

Merged
merged 28 commits into from
Oct 3, 2022
Merged

Refactor and redesign ContextMenu (#132) #147

merged 28 commits into from
Oct 3, 2022

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Sep 20, 2022 •
edited by SleepySquash
Loading

Resolves #132

Synopsis

Контекстное меню нужно зарефакторить и изменить его дизайн.

Solution

Необходимые изменения будут перенесены из new-design-preview и отрефакторены.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Sep 20, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.6 milestone Sep 20, 2022
@krida2000 krida2000 self-assigned this Sep 20, 2022
@krida2000
Copy link
Contributor Author

krida2000 commented Sep 22, 2022 •
edited by SleepySquash
Loading

FCM

Refactor and redesign `ContextMenu` (#147, #132)

- impl `ConfirmDialog` with `ConfirmDialogVariant`s
- impl animated `FloatingContextMenu` for mobile
- remove `ContextMenuOverlay` and use `showDialog` instead

Additionally:
- fix lags when entering gallery on mobile
- fix `Video` missing context menu
- make `Config.files` respect `Config.url` by default
- remove `_NestedHomeView`

@krida2000 krida2000 marked this pull request as ready for review September 22, 2022 13:17
SleepySquash
SleepySquash requested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000

lib/ui/widget/context_menu/region.dart Outdated Show resolved Hide resolved
lib/ui/widget/context_menu/region.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/widget/chat_item.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/chat/widget/chat_item.dart Outdated Show resolved Hide resolved
lib/ui/widget/context_menu/mobile.dart Show resolved Hide resolved
lib/ui/widget/context_menu/menu.dart Outdated Show resolved Hide resolved
lib/ui/widget/modal_popup.dart Outdated Show resolved Hide resolved
@SleepySquash
Copy link
Contributor

@krida2000, и поправьте FCM, пожалуйста.

@SleepySquash SleepySquash marked this pull request as draft September 27, 2022 08:49
@krida2000 krida2000 marked this pull request as ready for review September 30, 2022 08:42
SleepySquash
SleepySquash approved these changes Oct 3, 2022
View reviewed changes
android/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
lib/ui/page/home/widget/confirm_dialog.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/confirm_dialog.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/confirm_dialog.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash enabled auto-merge (squash) October 3, 2022 12:35
@SleepySquash SleepySquash merged commit 3f99ada into main Oct 3, 2022
@SleepySquash SleepySquash deleted the 132-refactor-context-menu branch October 3, 2022 13:06
github-actions bot added a commit that referenced this pull request Oct 3, 2022
@github-actions
Refactor and redesign ContextMenu (#147, #132)
b6f2b2e 
- impl `ConfirmDialog` with `ConfirmDialogVariant`s
- impl animated `FloatingContextMenu` for mobile
- remove `ContextMenuOverlay` and use `showDialog` instead

Additionally:
- fix lags when entering gallery on mobile
- fix `Video` missing context menu
- make `Config.files` respect `Config.url` by default
- remove `_NestedHomeView` 3f99ada
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.6.1
Development

Successfully merging this pull request may close these issues.

Refactor and redesign ContextMenu
2 participants
@krida2000 @SleepySquash