Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign MyProfile page (#243) #244

Merged
merged 26 commits into from
Dec 21, 2022
Merged

Redesign MyProfile page (#243) #244

merged 26 commits into from
Dec 21, 2022

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Dec 7, 2022 •
edited by SleepySquash
Loading

Part of #243

Synopsis

Вкладка "меню" и страница пользователя переверстались.

Solution

Обновленный дизайн будет перенесен.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Dec 7, 2022
@krida2000 krida2000 added this to the 0.1.0-alpha.8 milestone Dec 7, 2022
@krida2000 krida2000 self-assigned this Dec 7, 2022
@krida2000 krida2000 linked an issue Dec 7, 2022 that may be closed by this pull request
Redesign MyProfile page #243
Closed
@krida2000 krida2000 changed the title Redesign MyProfile page Redesign MyProfile page (№243) Dec 7, 2022
@krida2000 krida2000 changed the title Redesign MyProfile page (№243) Redesign MyProfile page (#243) Dec 7, 2022
@krida2000
Copy link
Contributor Author

krida2000 commented Dec 12, 2022 •
edited by SleepySquash
Loading

FCM

Redesign `Menu` tab and `MyProfile` page (#244, #243)

- impl `approvable` behaviour to `ReactiveTextField`
- impl `FieldButton`
- remove `Personalization` and `Settings` pages

@krida2000 krida2000 marked this pull request as ready for review December 12, 2022 15:10
@krida2000 krida2000 removed a link to an issue Dec 13, 2022
Redesign MyProfile page #243
Closed
@krida2000 krida2000 linked an issue Dec 14, 2022 that may be closed by this pull request
Redesign MyProfile page #243
Closed
SleepySquash
SleepySquash requested changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, пока отписываю те моменты, которые нашёл. Вычитайте ещё разочек задачку, пожалуйста, тут очень много строк, можно легко что-то упустить из виду и запутаться, у меня уже получилось запутаться :)

lib/ui/page/home/page/my_profile/view.dart Outdated Show resolved Hide resolved
lib/ui/widget/text_field.dart Show resolved Hide resolved
lib/ui/page/home/page/my_profile/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/my_profile/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft December 15, 2022 09:56
@krida2000 krida2000 marked this pull request as ready for review December 19, 2022 10:01
SleepySquash
SleepySquash requested changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, кнопочки FieldButton не работают с trailingом так, как должны :(

lib/ui/page/home/page/my_profile/widget/field_button.dart Outdated Show resolved Hide resolved
lib/ui/page/home/page/my_profile/view.dart Show resolved Hide resolved
lib/ui/page/home/page/my_profile/view.dart Show resolved Hide resolved
lib/ui/page/home/tab/menu/view.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/menu/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash merged commit c835c7e into main Dec 21, 2022
@SleepySquash SleepySquash deleted the 243-redesign-my-profile-page branch December 21, 2022 12:55
github-actions bot added a commit that referenced this pull request Dec 21, 2022
@github-actions
Redesign Menu tab and MyProfile page (#244, #243)
cfde83d 
- impl `approvable` behaviour to `ReactiveTextField`
- impl `FieldButton`
- remove `Personalization` and `Settings` pages

Co-authored-by: SleepySquash <nordnikita@icloud.com> c835c7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.8
Development

Successfully merging this pull request may close these issues.

Redesign MyProfile page
2 participants
@krida2000 @SleepySquash