Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mirror local video when environment camera is used (#70) #301

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Jan 5, 2023

Resolves #70

Synopsis

На мобильных устройствах задняя камера не должна отзеркаливатся.

Solution

Проблема будет исправлена.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes waiting::materials There is a need for additional actions/info (temporary) labels Jan 5, 2023
@krida2000 krida2000 added this to the 0.1.0-alpha.8 milestone Jan 5, 2023
@krida2000 krida2000 self-assigned this Jan 5, 2023
@SleepySquash
Copy link
Contributor

@krida2000, стоит актуализировать и посмотреть, не появился ли в medea_jason нужный нам индикатор. Дополнительно стоит LocalTrack.onStopped посмотреть и если он появился, то по нему нужно треки удалять в вебе - например, когда расшарка закрывается по клику на "Прекратить расшарку" браузера (а не по кнопке в доке).

@krida2000 krida2000 removed the waiting::materials There is a need for additional actions/info (temporary) label Sep 12, 2023
@krida2000
Copy link
Contributor Author

krida2000 commented Sep 14, 2023

FCM

Account `FacingMode` to mirror `VideoView` in mobile `Call`s (#301, #70)

Adittionally:
- remove tracks on `LocalMediaTrack.onEnded` callback

@krida2000 krida2000 marked this pull request as ready for review September 14, 2023 11:00
@SleepySquash SleepySquash enabled auto-merge (squash) September 18, 2023 09:48
@SleepySquash SleepySquash merged commit 73b7725 into main Sep 18, 2023
21 checks passed
@SleepySquash SleepySquash deleted the 70-not-mirror-environment-camera branch September 18, 2023 09:51
github-actions bot added a commit that referenced this pull request Sep 18, 2023
Adittionally:
- remove tracks on `LocalMediaTrack.onEnded` callback 73b7725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Do not mirror local video when environment camera is used
2 participants