Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Login interface #35

Merged
merged 41 commits into from
Jul 27, 2022
Merged

Redesign Login interface #35

merged 41 commits into from
Jul 27, 2022

Conversation

andrigel
Copy link
Contributor

@andrigel andrigel commented Jul 14, 2022 •
edited by tyranron
Loading

Synopsis

Был сверстан новый дизайн логина.

Solution

Нужно перенести изменения затрагивающие дизайн логина, протестировать и вычитать их.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@andrigel andrigel added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jul 14, 2022
@andrigel andrigel added this to the 0.1.0-alpha.6 milestone Jul 14, 2022
@andrigel andrigel self-assigned this Jul 14, 2022
@andrigel andrigel marked this pull request as draft July 14, 2022 06:46
@andrigel
Copy link
Contributor Author

andrigel commented Jul 19, 2022 •
edited by SleepySquash
Loading

FCM

Redesign `Login` UI/UX (#35)

- impl styled `ModalPopup`
- replace `Login` page with redesigned `Login` modal popup

Additionally:
- add `Roboto` font to assets
- add `maxWidth` and `height` fields to `OutlinedRoundButton` 
- add `prefix`, `trailing`, `filled` and `treatErrorAsStatus` fields to `ReactiveTextField`

@andrigel andrigel changed the title Redesign Login Redesign Login interface Jul 19, 2022
@andrigel andrigel marked this pull request as ready for review July 19, 2022 08:31
SleepySquash
SleepySquash requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel, нет, всё-таки слишком много всего нужно проверить, пересмотреть и протестировать, а тут можно разбить задачу на несколько более мелких. Предлагаю:

  1. Тут оставить только то, что относится к новому дизайну модального окошка логина.
  2. Вынести IntroductionView и связанную с ним логику в отдельный PR, который будет зависеть от этого (т.е. ждём слива логина, т.к. тут будет введён интерфейс попапа).
  3. Вынести ConfirmLogoutView в отдельный PR, аналогично тоже зависит от этого.

lib/ui/page/auth/widget/outlined_rounded_button.dart Outdated Show resolved Hide resolved
lib/ui/page/auth/login/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/auth/login/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/auth/login/controller.dart Outdated Show resolved Hide resolved
lib/ui/widget/context_menu/region.dart Outdated Show resolved Hide resolved
lib/ui/page/home/controller.dart Outdated Show resolved Hide resolved
assets/l10n/ru-RU.ftl Outdated Show resolved Hide resolved
lib/ui/page/home/introduction/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/home/tab/menu/confirm/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft July 19, 2022 11:06
SleepySquash
SleepySquash requested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrigel много мелочей. Просьба (уже далеко не первая) внимательнее относиться к замечаниям.

lib/ui/page/login/view.dart Outdated Show resolved Hide resolved
lib/ui/page/login/controller.dart Show resolved Hide resolved
lib/ui/page/login/view.dart Outdated Show resolved Hide resolved
lib/ui/page/login/view.dart Outdated Show resolved Hide resolved
lib/ui/page/login/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/login/view.dart Outdated Show resolved Hide resolved
lib/ui/page/login/view.dart Outdated Show resolved Hide resolved
lib/ui/page/login/controller.dart Outdated Show resolved Hide resolved
lib/ui/page/login/controller.dart Outdated Show resolved Hide resolved
lib/ui/widget/context_menu/overlay.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash marked this pull request as draft July 20, 2022 08:56
@andrigel andrigel marked this pull request as ready for review July 21, 2022 07:59
@SleepySquash SleepySquash added the k::refactor Refactor changes of existing code label Jul 25, 2022
@tyranron tyranron enabled auto-merge (squash) July 27, 2022 09:18
@tyranron tyranron merged commit 87aa663 into main Jul 27, 2022
@tyranron tyranron deleted the login-design branch July 27, 2022 09:34
github-actions bot added a commit that referenced this pull request Jul 27, 2022
@github-actions
Redesign Login UI/UX (#35)
95d765b 
- impl styled `ModalPopup`
- replace `Login` page with redesigned `Login` modal popup

Additionally:
- add `Roboto` font to assets
- add `maxWidth` and `height` fields to `OutlinedRoundButton`
- add `prefix`, `trailing`, `filled` and `treatErrorAsStatus` fields to `ReactiveTextField`

Co-authored-by: SleepySquash <NordNikita@icloud.com> 87aa663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@andrigel andrigel

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging this pull request may close these issues.
3 participants
@andrigel @tyranron @SleepySquash