Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call notifications #472

Merged
merged 10 commits into from
Jul 11, 2023
Merged

Call notifications #472

merged 10 commits into from
Jul 11, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Jul 7, 2023 •
edited by SleepySquash
Loading

Synopsis

В звонке появились уведомления.

Solution

Нужно перенести уведомления из new-design-preview

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Jul 7, 2023
@krida2000 krida2000 self-assigned this Jul 7, 2023
@krida2000
Copy link
Contributor Author

krida2000 commented Jul 10, 2023 •
edited by SleepySquash
Loading

FCM

Bootstrap `CallNotification`s in `OngoingCall` (#472)

- add `CallNotificationWidget` displaying `CallNotification`s in `Call`
- impl `DeviceChangedNotification`, `ErrorNotification`, `ConnectionLostNotification` and `ConnectionRestoredNotification`

Additionally: 
- add `OngoingCall.connectionLost` and its displaying in `Call`
- add `reconnect.mp3` sound playing in `Call` when connection is lost

@krida2000 krida2000 marked this pull request as ready for review July 10, 2023 07:43
SleepySquash
SleepySquash requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, подредактируйте цвета, пожалуйста.

assets/l10n/ru-RU.ftl Outdated Show resolved Hide resolved
lib/ui/page/call/widget/notification.dart Outdated Show resolved Hide resolved
lib/ui/page/call/widget/notification.dart Outdated Show resolved Hide resolved
lib/ui/page/call/component/desktop.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash added the k::refactor Refactor changes of existing code label Jul 11, 2023
@SleepySquash SleepySquash added this to the 0.1.0-alpha.9 milestone Jul 11, 2023
@SleepySquash SleepySquash merged commit 7ca9cec into main Jul 11, 2023
@SleepySquash SleepySquash deleted the call-notifications branch July 11, 2023 10:11
github-actions bot added a commit that referenced this pull request Jul 11, 2023
@github-actions
Bootstrap CallNotifications in OngoingCall (#472)
7f11973 
- add `CallNotificationWidget` displaying `CallNotification`s in `Call`
- impl `DeviceChangedNotification`, `ErrorNotification`, `ConnectionLostNotification` and `ConnectionRestoredNotification`

Additionally:
- add `OngoingCall.connectionLost` and its displaying in `Call`
- add `reconnect.mp3` sound playing in `Call` when connection is lost 7ca9cec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.9
Development

Successfully merging this pull request may close these issues.
2 participants
@krida2000 @SleepySquash