Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ContextMenu called twice longpressing on element (#508) #599

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix ContextMenu called twice longpressing on element (#508) #599

merged 3 commits into from
Sep 20, 2023

Conversation

drygbezdrug
Copy link
Contributor

@drygbezdrug drygbezdrug commented Sep 20, 2023 •
edited by SleepySquash
Loading

Resolves #508

Synopsis

В трех местах контекстное меню вызывается два раза при долгом нажатии

Solution

Добавил enableLongTap : false

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@drygbezdrug drygbezdrug added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Sep 20, 2023
@drygbezdrug drygbezdrug added this to the 0.1.0-alpha.10 milestone Sep 20, 2023
@drygbezdrug
Copy link
Contributor Author

drygbezdrug commented Sep 20, 2023 •
edited by SleepySquash
Loading

FCM

Fix `ContextMenuRegion` displaying multiple `ContextMenu`s (#599, #508)

@drygbezdrug drygbezdrug marked this pull request as ready for review September 20, 2023 09:55
@drygbezdrug drygbezdrug changed the title Fix ContextMenu called twice on element (#508) Fix ContextMenu called twice longpressing on element (#508) Sep 20, 2023
@SleepySquash SleepySquash merged commit 726a7c3 into main Sep 20, 2023
21 checks passed
@SleepySquash SleepySquash deleted the 508-fix-contextmenu-called-twice-when-longpress-on-element branch September 20, 2023 12:20
github-actions bot added a commit that referenced this pull request Sep 20, 2023
@github-actions
Fix ContextMenuRegion displaying multiple ContextMenus (#599, #508)
d9b49b1 
Co-authored-by: SleepySquash <nordnikita@icloud.com> 726a7c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@drygbezdrug drygbezdrug

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.10
Development

Successfully merging this pull request may close these issues.

ContextMenu called twice when longpress on ChatsMenuButton
2 participants
@drygbezdrug @SleepySquash