Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Widgets tab on Style page (#632) #695

Merged
merged 25 commits into from
Nov 15, 2023
Merged

Redesign Widgets tab on Style page (#632) #695

merged 25 commits into from
Nov 15, 2023

Conversation

krida2000
Copy link
Contributor

@krida2000 krida2000 commented Nov 2, 2023 •
edited by SleepySquash
Loading

Resolves #632

Synopsis

Нужно обновить дизайн вкладки виджеты.

Solution

Изменения будут перенесены из new-design-preview

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@krida2000 krida2000 added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Nov 2, 2023
@krida2000 krida2000 added this to the 0.1.0-alpha.12 milestone Nov 2, 2023
@krida2000 krida2000 self-assigned this Nov 2, 2023
@krida2000
Copy link
Contributor Author

FCM

Redesign `Widget`s tab on `Style` page (#695, #632)

@krida2000 krida2000 marked this pull request as ready for review November 7, 2023 11:51
SleepySquash
SleepySquash requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krida2000, пока мысли о DummyRxUserах и чатах в голове висят, пожалуйста, давайте небольшой рефакторик проведём, если возможно, и пару моментов обсудим.

lib/ui/page/style/page/widgets/widget/playable_asset.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/gallery_popup.dart Outdated Show resolved Hide resolved
lib/ui/page/home/widget/block.dart Outdated Show resolved Hide resolved
lib/domain/model/native_file.dart Outdated Show resolved Hide resolved
lib/ui/page/style/page/widgets/view.dart Outdated Show resolved Hide resolved
lib/ui/page/style/page/widgets/view.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash mentioned this pull request Nov 9, 2023
Closed
4 tasks
SleepySquash
SleepySquash approved these changes Nov 15, 2023
View reviewed changes
lib/ui/page/home/widget/block.dart Outdated Show resolved Hide resolved
lib/ui/page/call/widget/call_button.dart Outdated Show resolved Hide resolved
lib/ui/page/style/page/widgets/section/chat.dart Outdated Show resolved Hide resolved
@SleepySquash SleepySquash merged commit 84f2ba1 into main Nov 15, 2023
21 checks passed
@SleepySquash SleepySquash deleted the 632-redesign-widgets-tab-on-style-page branch November 15, 2023 11:15
github-actions bot added a commit that referenced this pull request Nov 15, 2023
@github-actions
Redesign Widgets tab on Style page (#695, #632)
668ccfa 
Co-authored-by: SleepySquash <nordnikita@icloud.com> 84f2ba1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleepySquash SleepySquash SleepySquash approved these changes

Assignees

@krida2000 krida2000

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.1.0-alpha.11.1
Development

Successfully merging this pull request may close these issues.

Redesign Widgets tab on Style page
2 participants
@krida2000 @SleepySquash