Generate name for StorageFile based on its mime type (#726)

CHANGELOG.md

@@ -24,9 +24,13 @@ All user visible changes to this project will be documented in this file. This p
         - Restore button displaying under mobile navigation bar. ([#763, #758])
     - Contacts tab:
         - Restore button displaying under mobile navigation bar. ([#763, #758])
+    - User page:
+        - Downloaded avatar missing its extension on desktop. ([#756, #726])
 
 [#718]: /../../issues/718
+[#726]: /../../issues/726
 [#750]: /../../pull/750
+[#756]: /../../pull/756
 [#758]: /../../issues/758
 [#763]: /../../pull/763
 

analysis_options.yaml

@@ -16,3 +16,4 @@ linter:
   # https://dart-lang.github.io/linter/lints/index.html
   rules:
     prefer_single_quotes: true
+    prefer_relative_imports: true

lib/domain/model/file.dart

@@ -15,6 +15,7 @@
 // along with this program. If not, see
 // <https://www.gnu.org/licenses/agpl-3.0.html>.
 
+import 'package:intl/intl.dart';
 import 'package:hive/hive.dart';
 
 import '../model_type_id.dart';
@@ -70,6 +71,36 @@ abstract class StorageFile extends HiveObject {
 
   /// Returns an absolute URL to this [StorageFile] on a file storage.
   String get url => '${Config.files}$relativeRef';
+
+  /// Returns the name of this [StorageFile].
+  String get name {
+    final basename = DateFormat('yyyy_MM_dd_H_m_s').format(DateTime.now());
+    return [basename, _extension].nonNulls.join('.');
+  }
+
+  /// Returns the extension parsed from the [relativeRef], excluding the dot, if
+  /// any.
+  ///
+  /// ```dart
+  /// var file = StorageFile(relativeRef: 'http://site/.jpg');
+  /// print(file._extension); // => 'jpg'
+  ///
+  /// var file = StorageFile(relativeRef: 'http://site/noExtension');
+  /// print(file._extension); // => 'null'
+  /// ```
+  String? get _extension {
+    final index = url.lastIndexOf('.');
+    if (index < 0 || index + 1 >= url.length) {
+      return null;
+    }
+
+    final result = url.substring(index + 1).toLowerCase();
+    if (result.contains('/')) {
+      return null;
+    }
+
+    return result;
+  }
 }
 
 /// Plain-[StorageFile] on a file storage.

lib/ui/page/home/widget/big_avatar.dart

@@ -215,7 +215,7 @@ class _BigAvatarWidgetState extends State<BigAvatarWidget> {
                     children: [
                       GalleryItem.image(
                         avatar!.original.url,
-                        avatar.original.checksum ?? DateTime.now().toString(),
+                        avatar.original.name,
                         width: avatar.original.width,
                         height: avatar.original.height,
                         checksum: avatar.original.checksum,

lib/ui/page/home/widget/gallery_popup.dart

@@ -651,7 +651,15 @@ class _GalleryPopupState extends State<GalleryPopup>
                         constraints:
                             const BoxConstraints(minWidth: 1, minHeight: 1),
                         child: PlatformUtils.isWeb
-                            ? WebImage(e.link, onForbidden: e.onError)
+                            ? WebImage(
+                                e.link,
+                                onForbidden: e.onError,
+
+                                // TODO: Wait for HTML to support specifying
+                                //       download name:
+                                //       https://github.com/whatwg/html/issues/2722
+                                // name: e.name,
+                              )
                             : RetryImage(
                                 e.link,
                                 width: e.width?.toDouble(),