Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign ContextMenu on Desktop to display SvgIcons #757

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Redesign ContextMenu on Desktop to display SvgIcons #757

merged 7 commits into from
Dec 20, 2023

Conversation

SleepySquash
Copy link
Contributor

@SleepySquash SleepySquash commented Dec 20, 2023 •
edited
Loading

Synopsis

It was decided that ContextMenu on desktop should be a bit more refined and contain icons.

Solution

This PR refactors ContextMenu to display icons on desktop platforms.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Dec 20, 2023
@SleepySquash SleepySquash added this to the 0.1.0-alpha.12 milestone Dec 20, 2023
@SleepySquash SleepySquash self-assigned this Dec 20, 2023
@SleepySquash
Copy link
Contributor Author

SleepySquash commented Dec 20, 2023 •
edited
Loading

FCM

Redesign `ContextMenuButton` to display `trailing` on desktop platforms (#757) 

- add `ContextMenuButton.inverted` icon

Additionally:
- replace `NotoSans` font with `Roboto`

@SleepySquash SleepySquash marked this pull request as ready for review December 20, 2023 13:15
@SleepySquash SleepySquash merged commit d16588e into main Dec 20, 2023
21 checks passed
@SleepySquash SleepySquash deleted the add-icons-to-desktop-menu branch December 20, 2023 14:42
github-actions bot added a commit that referenced this pull request Dec 20, 2023
@github-actions
Redesign ContextMenuButton to display trailing on desktop platfor…
ea59d82 
…ms (#757)

- add `ContextMenuButton.inverted` icon

Additionally:
- replace `NotoSansDisplay` font with `Roboto` d16588e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes
Projects
Roadmap
Status: Done
Milestone
0.1.0-alpha.11.1
Development

Successfully merging this pull request may close these issues.
1 participant
@SleepySquash