Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Helm chart deploying #85

Merged
merged 5 commits into from
Aug 23, 2022
Merged

Implement Helm chart deploying #85

merged 5 commits into from
Aug 23, 2022

Conversation

SleepySquash
Copy link
Contributor

@SleepySquash SleepySquash commented Aug 19, 2022 •
edited by tyranron
Loading

Synopsis

Helm chart can be built and released, now it's time to add toolchain for its deployment.

Solution

Add toolchain deploying the Helm chart.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added feature New feature or request k::deploy Changes that involve application deployment k::toolchain Changes of project toolchain labels Aug 19, 2022
@SleepySquash SleepySquash added this to the 0.1.0-alpha.6 milestone Aug 19, 2022
@SleepySquash SleepySquash self-assigned this Aug 19, 2022
@SleepySquash
Copy link
Contributor Author

SleepySquash commented Aug 19, 2022 •
edited
Loading

FCM

Implement Helm chart deploying (#85) 

Additionally:
- add `buildx` parameter to `docker.image` Makefile command

@SleepySquash SleepySquash marked this pull request as ready for review August 19, 2022 12:20
@SleepySquash SleepySquash added the enhancement Improvement of existing features or bugfix label Aug 19, 2022
@tyranron tyranron enabled auto-merge (squash) August 23, 2022 13:49
@tyranron tyranron merged commit db47c98 into main Aug 23, 2022
@tyranron tyranron deleted the deploy-helm-chart branch August 23, 2022 14:08
github-actions bot added a commit that referenced this pull request Aug 23, 2022
@github-actions
Implement Helm chart deploying (#85)
d590a3c 
Additionally:
- add `buildx` parameter to `docker.image` Makefile command

Co-authored-by: Kai Ren <tyranron@gmail.com> db47c98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@SleepySquash SleepySquash

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::deploy Changes that involve application deployment k::toolchain Changes of project toolchain
Projects
None yet
Milestone
0.1.0-alpha.6
Development

Successfully merging this pull request may close these issues.
2 participants
@SleepySquash @tyranron