Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bit link should not run if there are no dists present #2340

Closed
odedre opened this issue Feb 13, 2020 · 1 comment
Closed

bit link should not run if there are no dists present #2340

odedre opened this issue Feb 13, 2020 · 1 comment
Assignees
Milestone

Comments

@odedre
Copy link
Member

odedre commented Feb 13, 2020

Describe the bug

if I run the command bit link without building first, and there are no dists present, bit should indicate this with an error.

Steps to Reproduce

  1. import a compiler
  2. create a component
  3. run bit add
  4. run bit link
  5. bit creates links that point to an empty folder

Expected Behavior

either:

bit should indicate with warning that there are no dists present and the links that were created might be wrong

or:

bit link should not run and throw error instead

Specifications

  • Bit version: 14.7.4
  • Node version: v10.15.3
  • yarn version: 1.13.0
  • Platform: macos
  • Bit compiler (include version): bit.envs/compilers/react-typescript@3.1.43
@davidfirst
Copy link
Member

In the next major version (Harmony), the links will be different, they might point to the capsules or to the source inside the workspace. Probably not to the dists.

@GiladShoham GiladShoham added this to the harmony release v1.0 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants