Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changing logging channel doesn't remove old channel #202

Closed
wakfi opened this issue Sep 3, 2021 · 3 comments
Closed

[BUG] Changing logging channel doesn't remove old channel #202

wakfi opened this issue Sep 3, 2021 · 3 comments
Labels
bug Something isn't working needs repro This issue is not being reproduced successfully

Comments

@wakfi
Copy link
Member

wakfi commented Sep 3, 2021

Describe the bug
When logging is enabled already for a log type, if you run the command again and give a different channel, the logs for the type will be sent to both channels.

To Reproduce
Steps to reproduce the behavior:

  1. Run !cfg logging message_logs <some channel>
  2. Delete or edit a message and see it logged in the channel
  3. Run !cfg logging message_logs <some_other_channel>
  4. Delete or edit a message and see it logged in both channels

Expected behavior
Logs are no longer sent to the old channel, only the new one

Additional context
Is this actually a feature?

@wakfi wakfi added the bug Something isn't working label Sep 3, 2021
@y3ll0wlife
Copy link
Member

y3ll0wlife commented Sep 11, 2021

CNR on TS 3.2.0.5 (bbd8c8c) build #bbd8c8c

@KlukCZ
Copy link
Member

KlukCZ commented Sep 11, 2021

CNR, this should not even be possible as the logging channel is not an array in the database nor does the logger loop through all the channels

@wakfi wakfi added the needs repro This issue is not being reproduced successfully label Sep 11, 2021
@wakfi
Copy link
Member Author

wakfi commented Sep 11, 2021

CNLR. See #215 for alternate, related issue

@wakfi wakfi closed this as completed Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs repro This issue is not being reproduced successfully
Projects
None yet
Development

No branches or pull requests

3 participants