Log clean up. #32
Merged
Log clean up. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rssanders3
requested changes
Feb 7, 2019
log-cleanup/airflow-log-cleanup.py
Outdated
| if CHILD_PROCESS_LOG_DIRECTORY is not ' ': | ||
| DIRECTORIES_TO_DELETE.append( CHILD_PROCESS_LOG_DIRECTORY ) | ||
| except Exception: | ||
| logging.info("CHILD process directory path not available!!") |
There was a problem hiding this comment.
Use logging.error() and print exception stacktrace
log-cleanup/airflow-log-cleanup.py
Outdated
| BASE_LOG_FOLDER='""" + BASE_LOG_FOLDER + """' | ||
| BASE_LOG_FOLDER=""{{params.directory}}"" | ||
| TYPES=""{{params.type}}"" | ||
| DELETE_TYPE=""{{params.deleteType}}"" |
There was a problem hiding this comment.
This is never set based off the task definitions
log-cleanup/airflow-log-cleanup.py
Outdated
| @@ -58,17 +73,22 @@ | |||
| echo "BASE_LOG_FOLDER: '${BASE_LOG_FOLDER}'" | |||
| echo "MAX_LOG_AGE_IN_DAYS: '${MAX_LOG_AGE_IN_DAYS}'" | |||
| echo "ENABLE_DELETE: '${ENABLE_DELETE}'" | |||
| echo "" | |||
| echo "TYPE: '${TYPE}'" | |||
There was a problem hiding this comment.
Add an extra space so ${TYPE} lines up with the print statements above it
log-cleanup/airflow-log-cleanup.py
Outdated
| ENABLE_DELETE_CHILD_LOG = Variable.get("enable_delete_child_log", "False") | ||
| logging.info("ENABLE_DELETE_CHILD_LOG " + ENABLE_DELETE_CHILD_LOG) | ||
|
|
||
| if ENABLE_DELETE_CHILD_LOG == "True": |
There was a problem hiding this comment.
See if you can ignore case because people might enter in all lower case
added 2 commits
February 12, 2019 19:56
rssanders3
approved these changes
Feb 14, 2019
This was referenced Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options for delete empty folders and cleanup CHILD_PROCESS_LOG directory