Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deis builder should do best effort to keep git checkout #21

Open
Cryptophobia opened this issue Mar 21, 2018 · 2 comments
Open

Deis builder should do best effort to keep git checkout #21

Cryptophobia opened this issue Mar 21, 2018 · 2 comments

Comments

@Cryptophobia
Copy link
Member

From @deis-admin on January 19, 2017 23:52

From @nathansamson on March 22, 2015 15:0

I udnerstand that deis builder will throw away all git checkouts it has on a reboot / node movement.

Problem is when pushing a branch with rather some history, this might take a while every time.

I think deis builder should do a best (better than currently) to keep a quick checkout of branches.
I am thinking of a new container / volume that has all repos, that can be fetched.
Ofcourse in case that is down, or the repo isn't available there it must keep current behaviour to just repush the branch from scratch..

This will be even more important when deis builder is scalable (I hope there are plans for this) in large clusters

Hreoku displays "fetching branch" when pushign to an existing app, so I assume they push branches to a central (but distributed) location, fetch it locally from the datacenter (which should be fast), and then accepts new pushes from there on.
I hope we can achieve something similar...

Copied from original issue: deis/deis#3355

Copied from original issue: deis/builder#471

@Cryptophobia
Copy link
Member Author

From @deis-admin on January 19, 2017 23:52

From @carmstrong on April 9, 2015 21:9

I think this could be achieved by having builder consume a deis-store-volume mount. This is an optimization that we could see being optional for users who want this performance improvement.

@Cryptophobia
Copy link
Member Author

From @universlabs on August 2, 2017 14:55

This is really important for teams to ensure people don't push changes that are behind the head of the branch, avoiding accidental regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant