chore(deps): Updates for additional AWS Regions support #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pip install --disable-pip-version-check --no-cache-dir --upgrade \ | ||
| git+https://github.com/teamhephy/boto@abb38474ee5124bb571da0c42be67cd27c47094f \ |
There was a problem hiding this comment.
This is a big risky, how do we know upgrading to boto==2.49.0 from `abb38474ee5124bb571da0c42be67cd27c47094f1 won't break anything major?
There was a problem hiding this comment.
We've been running this in production clusters without any issues for a few months now.
There was a problem hiding this comment.
Also, this commit doesn't exist. When trying to build the master branch I get the following error:
Collecting git+https://github.com/teamhephy/boto@abb38474ee5124bb571da0c42be67cd27c47094f
Cloning https://github.com/teamhephy/boto (to abb38474ee5124bb571da0c42be67cd27c47094f) to /tmp/pip-bkonudg6-build
Could not find a tag or branch 'abb38474ee5124bb571da0c42be67cd27c47094f', assuming commit.
There was a problem hiding this comment.
Very good point @jfueschl! 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to registry 2.7.1 and boto 2.49.0 in order to add support for newer AWS Regions.