Deprecating Tcell WAF module support #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious about what the linting deadline param does, otherwise this LGTM. Looks like I already removed the module itself in 8c75726, but forgot the config stuff. |
felixbuenemann
suggested changes
Sep 11, 2019
notmaxx
approved these changes
Sep 11, 2019
We no longer have access to pre-compiled nginx Tcell.io modules so we are deprecating this feature. Modsecurity open source module is the default suported option now for WAF security on the router.
Cryptophobia
force-pushed
the
master
branch
from
cd8c0fe
to
d253929
Compare
@felixbuenemann , yes. this PR was just meant to cleanup and remove the left over configuration and annotation variables. |
|
Thank you guys @notmaxx @felixbuenemann ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer have access to nginx Tcell.io security module builds so we are deprecating this support of Tcell.io nginx WAF on the router. Open source Modsecurity will be default option for WAF security.