Reintroduce workaround for arm64 to use rosetta #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonoPrest
commented
May 9, 2022
| @@ -13,6 +13,11 @@ if (platform === "win32") { | |||
| platform = "win"; | |||
| } | |||
|
|
|||
| // Workaround for arm64 to use Rosetta for now | |||
| if (arch === "arm64") { | |||
There was a problem hiding this comment.
I have changed this code from:
if (platform === "darwin" && arch === "arm64") {
arch = "x64";
}So that it will assign the x64 file no matter what platform. The platform could vary based on docker containers so darwin is not the only possible platform.
There was a problem hiding this comment.
Won't e.g. a raspberryPi also be process.arch == "arm64"?
There was a problem hiding this comment.
Ah - yes of course. Its not so simple :(
I will close the PR for now and just use my own workaround script. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI @jfrolich and graphql-ppx team!
I would like to open a pull request to reintroduce this work around for arm64 macs to be able to use rosetta.
I'm not entirely sure what the reasoning for removing this workaround was on the latest update but I would be a very appreciative developer if it could be reintroduced.
I have also modified the
ifstatement to only check whether process.arch is"arm64"and not to specifically require process.platform to equal"darwin". This is because using the new optimized docker for apple silicon one could be running a container with linux in an arm64 environment for example and it would still work perfectly using the graphql-ppx-linux-x64.exe.This has been the case for me on a current project and I've had code in a virtual environment in order to work with graphql-ppx.
Thanks very much.