Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict values passed from initial optimisation to relaxed-rate model #34

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

joshwlambert
Copy link
Collaborator

This PR puts an upper limit on initial parameter values that can be passed into the relaxed-rate DAISIE model. The upper limits are dependent on not allowing infinite values passed into DAISIE and to prevent values about the specified parameter upper bound.

@Neves-P If you agree I will make a minor version release after these changes are merged.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (99fc626) 65.75% compared to head (8e1dbc4) 65.58%.

❗ Current head 8e1dbc4 differs from pull request most recent head 016bba0. Consider uploading reports for the commit 016bba0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   65.75%   65.58%   -0.17%     
==========================================
  Files          25       25              
  Lines        1203     1206       +3     
==========================================
  Hits          791      791              
- Misses        412      415       +3     
Files Coverage Δ
R/run_daisie_ml.R 65.55% <0.00%> (-2.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshwlambert joshwlambert merged commit 9670906 into master Oct 20, 2023
13 of 15 checks passed
@joshwlambert joshwlambert deleted the develop branch October 20, 2023 09:12
@joshwlambert joshwlambert restored the develop branch October 20, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants