Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous changes #31

Merged
merged 11 commits into from
May 3, 2023
Merged

Miscellaneous changes #31

merged 11 commits into from
May 3, 2023

Conversation

joshwlambert
Copy link
Collaborator

This PR makes a few small changes to the package.

  • The version of R and DAISIE are incremented to 4.2 and 4.4.0, respectively
  • The relaxed-rate DAISIE model now has an initial DAISIE optimisation to get better initial conditions (in run_daisie_ml.R)
  • Removed an old documentation section causing warning

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #31 (86b05ff) into master (5e8a570) will decrease coverage by 0.98%.
The diff coverage is 5.26%.

❗ Current head 86b05ff differs from pull request most recent head 91b7bb4. Consider uploading reports for the commit 91b7bb4 to get more accurate results

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   66.77%   65.80%   -0.98%     
==========================================
  Files          25       25              
  Lines        1183     1202      +19     
==========================================
+ Hits          790      791       +1     
- Misses        393      411      +18     
Impacted Files Coverage Δ
R/run_daisie_ml.R 68.60% <5.26%> (-17.97%) ⬇️

@joshwlambert joshwlambert merged commit 9472c2a into master May 3, 2023
@joshwlambert joshwlambert deleted the develop branch May 3, 2023 10:57
@joshwlambert joshwlambert restored the develop branch May 3, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants