We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently we only can specify the parentElement by a text css selector. It would be good to set the parentElement as HTMLElement instance too.
To allow this, we have to changed the following code in cupertino-pane.ts
from if (this.settings.parentElement) { this.settings.parentElement = document.querySelector( this.settings.parentElement ); } else { this.settings.parentElement = this.el.parentElement; }
to if (this.settings.parentElement && !this.settings.parentElement instanceOf HTMLElement) { this.settings.parentElement = document.querySelector( this.settings.parentElement ); } else { this.settings.parentElement = this.el.parentElement; }
The text was updated successfully, but these errors were encountered:
Hello @tobium Thank you for proposal. Could you please create pull request with this simple changes ?
Sorry, something went wrong.
@tobium let me know if you need this as soon as possible. Otherwise better new pull request, so you will be in contributors also.
feat(settings): parent instance as HTMLElement or string (#193)
56049ae
roman-rr
No branches or pull requests
Currently we only can specify the parentElement by a text css selector. It would be good to set the parentElement as HTMLElement instance too.
To allow this, we have to changed the following code in cupertino-pane.ts
from
if (this.settings.parentElement) {
this.settings.parentElement = document.querySelector(
this.settings.parentElement
);
} else {
this.settings.parentElement = this.el.parentElement;
}
to
if (this.settings.parentElement && !this.settings.parentElement instanceOf HTMLElement) {
this.settings.parentElement = document.querySelector(
this.settings.parentElement
);
} else {
this.settings.parentElement = this.el.parentElement;
}
The text was updated successfully, but these errors were encountered: