Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE/#303 CI 에러 수정 #304

Merged
merged 1 commit into from
Nov 22, 2023
Merged

BE/#303 CI 에러 수정 #304

merged 1 commit into from
Nov 22, 2023

Conversation

youKeon
Copy link
Collaborator

@youKeon youKeon commented Nov 22, 2023 •
edited
Loading

🛠️ 변경사항

  • 에러가 발생한 코드 수정
  • ProjectIntegrationTest 삭제


☝️ 유의사항



👀 참고자료



❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

@youKeon youKeon added the 오류 수정 Something isn't working label Nov 22, 2023
@github-actions GitHub Actions
Copy link

Unit Test Results

84 tests  +84   84 ✔️ +84   3s ⏱️ +3s
16 suites +16     0 💤 ±  0 
16 files   +16     0 ❌ ±  0 

Results for commit a161edb. ± Comparison against base commit 91ff18d.

baekhangyeol
baekhangyeol approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@baekhangyeol baekhangyeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!👍

kimhalin
kimhalin approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@kimhalin kimhalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르시네요🥲 제가 같은 브랜치에서 한 번 더 작업해서 코드가 깨졌었나봐요..!

@youKeon youKeon merged commit 541c6f5 into feature Nov 22, 2023
3 checks passed
@youKeon youKeon deleted the BE/#303 branch November 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekhangyeol baekhangyeol baekhangyeol approved these changes

@kimhalin kimhalin kimhalin approved these changes

Assignees
No one assigned
Labels
오류 수정 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youKeon @kimhalin @baekhangyeol