Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.12 rc #513

Merged
merged 2 commits into from
Nov 30, 2023
Merged

V1.12 rc #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
864b920
Decode file name before submitting to aws client (#509)
GPaoloni Nov 27, 2023
b168ea7
Added option to use branches different than master on e2e for QA tag …
GPaoloni Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/hrm-qa-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ on:
title:
description: Release title - The title that will be given to this pre-release.
required: true
flex-branch:
description: The branch name or tag to run flex-plugins/e2e-tests - Defaults to master.
required: false
default: master

jobs:
build-and-deploy-service:
Expand Down Expand Up @@ -80,7 +84,7 @@ jobs:

# Clone flex-plugins repo
- name: Clone flex-plugins repo
run: git clone https://github.com/techmatters/flex-plugins
run: git clone https://github.com/techmatters/flex-plugins --branch ${{ inputs.flex-branch }} --single-branch
shell: bash

- name: Install Flex Plugin
Expand Down
18 changes: 15 additions & 3 deletions hrm-domain/lambdas/files-urls/parseParameters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,19 @@ export const parseParameters = (event: AlbHandlerEvent): ParseParametersResult =
return newErr({ message: ERROR_MESSAGES.MISSING_QUERY_STRING_PARAMETERS });
}

const { method, bucket, key, objectType, objectId, fileType } = queryStringParameters;
const method =
queryStringParameters.method && decodeURIComponent(queryStringParameters.method);
const bucket =
queryStringParameters.bucket && decodeURIComponent(queryStringParameters.bucket);
const key = queryStringParameters.key && decodeURIComponent(queryStringParameters.key);
const objectType =
queryStringParameters.objectType &&
decodeURIComponent(queryStringParameters.objectType);
const objectId =
queryStringParameters.objectId && decodeURIComponent(queryStringParameters.objectId);
const fileType =
queryStringParameters.fileType && decodeURIComponent(queryStringParameters.fileType);

const { accountSid } = parsePathParameters(path);
if (!method || !bucket || !key || !accountSid || !objectType || !fileType) {
return newErr({
Expand Down Expand Up @@ -115,10 +127,10 @@ export const parseParameters = (event: AlbHandlerEvent): ParseParametersResult =
method,
bucket,
key,
accountSid,
fileType: fileType as FileTypes,
objectType,
objectId,
fileType: fileType as FileTypes,
accountSid,
},
});
};
Loading