Minimal changes to allow compilation in Visual Studio

[jsbattig]

If you are interested, this changes allow compilation in Visual Studio and I think are not going to break Linux (I haven't tested the code)

[technion]

Hi,
Many thanks for this patch.
Note I don't expect the salt generator to work in Windows thanks to /dev/urandom, but if this patch is still useful I'm all for it.

Please allow me some time to fully QA it.

[jsbattig]

You are welcome.
Yes, the salt generator won't work, reason for which I added the #ifdef on
the header file.
I may put some time in the future to make it work in Windows, but I would
have to study /dev/urandom concept. I'm not well versed on Linux reason for
which I prefer to make the core of the library compatible and left the salt
generator off.

I have not tested yet the code. I will be doing so once I replace an
existing AES/CBC solution we have with AES/EAX and scrypt for key
generation.

Regards

Sebastian

On Tue, Sep 16, 2014 at 7:24 PM, technion notifications@github.com wrote:

Hi,
Many thanks for this patch.
Note I don't expect the salt generator to work in Windows thanks to
/dev/urandom, but if this patch is still useful I'm all for it.

Please allow me some time to fully QA it.

—
Reply to this email directly or view it on GitHub
#28 (comment).

[technion]

Just a note for those reading. I'm going to pull this patch in because it's small, unintrusive, and it's obvious what it's doing. That said, I really don't want to go the way of OpenSSL and introduce a maze of ifdef's based on various platforms. If it's going to take a one thousand line patch to work with platform x, I'd rather someone with access to that platform fork the project, than introduce massive code paths that I'm not testing.