Refactor, split code into modules #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade ts, jest
sheppardv
commented
Jan 28, 2021
| } | ||
|
|
||
| if (aliases.length > 0) { | ||
| Object.assign(params, aliases.reduce((acc, alias) => |
There was a problem hiding this comment.
This code also has no value since Object.assign returns new object but value is ignored.
Was it meant to reassign params?
There was a problem hiding this comment.
I’m pretty sure it transfers to the target as well as returns the updated target. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign. AFK to confirm though.
There was a problem hiding this comment.
My bad, you are totally right!
antonespo
approved these changes
Sep 19, 2021
wedgberto
reviewed
Apr 6, 2023
There was a problem hiding this comment.
It would be nice for the file name spelling to match the builder function spelling : aggregate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No new code created, just split.