Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle svelte-check warnings #186

Closed
4 of 5 tasks
techniq opened this issue Jan 5, 2024 · 6 comments
Closed
4 of 5 tasks

Handle svelte-check warnings #186

techniq opened this issue Jan 5, 2024 · 6 comments
Milestone

Comments

@techniq
Copy link
Owner

techniq commented Jan 5, 2024

  • Handle all svelte-check warnings (A11y, unused variables, etc) so the console is clean
    • Possibly leverage <!-- svelte-ignore ... --> temporarily
  • Setup CI to run svelte-check and fail build
  • If <!-- svelte-ignore ... --> or // @ts-expect-error are used, properly handle remaining items
  • Rinse/repeat in LayerChart
  • Enjoy a peaceful dev experience with improved accessibility

Reference

@jycouet
Copy link
Collaborator

jycouet commented May 6, 2024

in user land, if you add in svelte.config.js the function onwarn:

/** @type {import('@sveltejs/kit').Config} */
const config = {
	// ...

	onwarn(warning, defaultHandler) {
		// Do not show 3rd party warnings
		if (warning.filename.includes('node_modules')) return

		defaultHandler(warning)
	},

	// ...
}

export default config

I find it nice until it's "fixed" 😉

@techniq
Copy link
Owner Author

techniq commented Jun 23, 2024

Making good progress in PR #409

@techniq
Copy link
Owner Author

techniq commented Jun 23, 2024

zoolander-will-ferrell

image

image

@jycouet
Copy link
Collaborator

jycouet commented Jun 24, 2024

zoolander-will-ferrell zoolander-will-ferrell

image

image

That's AMAZING!!!!
Good job

@techniq
Copy link
Owner Author

techniq commented Jun 24, 2024

Thanks @jycouet. LayerChart is in progress as well

@techniq
Copy link
Owner Author

techniq commented Jun 27, 2024

Sorry for the delay, but Svelte UX 0.71.0 and LayerChart 0.43.0 now provide a much improved Typescript and A11y experience, and a clean console on startup 😁. Typescript and A11y improvements will continue, especially during the Svelte 5 migration. I would appreciate any help on on both of these (searching the codebase for <!-- svelte-ignore ... --> or // @ts-expect-error) as well

@techniq techniq closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants