-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Resolve the visual glitch in the Switch component that causes un… #269
Conversation
…expected spacing.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @Scorpio3310, but this will cause the input to no longer be focusable and thus toggle via the keyboard. CleanShot.2024-02-23.at.07.00.33.mp4Could share a video of the visual glitch you are seeing? |
Also sending the video of fixed bug. switch.mp4 |
Thanks @Scorpio3310, I didn't realize it was browser specific (only affects Arc and Brave, which are both Chromium-based). Interest I didn't see any issues with Chrome or Edge (also tested Safari and Firefox) |
Thanks @Scorpio3310. I tested on Arc, Brave, Chrome, Firefox, and Safari and I didn't see any regressions (other than the fixes for Arc/Brave). From a other testing with some of my co-workers, we think it's a regression with Chromium 122 (I'm still on Chrome 121). I didn't have the issue with Edge (also Chromium based) but just updated it, and saw the issue show up, and your fix resolves it. In the future, anytime you submit a PR, it's nice to generate a changeset using Thanks for finding this, investigating, and submitting the PR. |
I was this was still an issue on mobile Safari (
|
The input field has been modified from inline to hidden.