-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(build): major rework GitHub Actions Workflow #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks great! Have you tested the new version release part? It should automatically create a release and attach artifacts when creating a tag (I don't see a release on your fork atm) |
Yes, went as draft. See https://github.com/duhow/nuki_hub/releases/tag/8.37 |
Great. LGTM |
iranl
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of the
build.yaml
GitHub Actions.While there are some special stuff that is scripted, this is a good first step in towards simplifying the workflow.
Instead of copy-pasting the build commands, you can add new models by defining into the
matrix
.Changes
matrix.board
to list all boards available, andmatrix.build
forrelease
and/ordebug
process.job
, parallelizes machines and drops down the build time from 9 minutes to less than 2 minutes.flash.sh
command from docshow-to-flash.txt
, easy to mantain in a single place.Note
Suggest to do an
squash merge
, I don't think you'll need the testing commits.