Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build): major rework GitHub Actions Workflow #392

Merged
merged 16 commits into from
Jun 7, 2024

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Jun 5, 2024

This is a rework of the build.yaml GitHub Actions.
While there are some special stuff that is scripted, this is a good first step in towards simplifying the workflow.
Instead of copy-pasting the build commands, you can add new models by defining into the matrix.

Changes

  • Use matrix.board to list all boards available, and matrix.build for release and/or debug process.
  • Use same job, parallelizes machines and drops down the build time from 9 minutes to less than 2 minutes.
  • Get flash.sh command from docs how-to-flash.txt, easy to mantain in a single place.

▶️ See https://github.com/duhow/nuki_hub/actions/runs/9386652818 as run example.

Note

Suggest to do an squash merge, I don't think you'll need the testing commits.

@iranl
Copy link
Collaborator

iranl commented Jun 5, 2024

Looks great!

Have you tested the new version release part? It should automatically create a release and attach artifacts when creating a tag (I don't see a release on your fork atm)

@duhow
Copy link
Contributor Author

duhow commented Jun 5, 2024

Yes, went as draft. See https://github.com/duhow/nuki_hub/releases/tag/8.37

@iranl
Copy link
Collaborator

iranl commented Jun 5, 2024

Great. LGTM

@iranl iranl modified the milestone: 8.35 Jun 5, 2024
@iranl iranl added enhancement New feature or request labels Jun 5, 2024
@technyon technyon merged commit d085186 into technyon:master Jun 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants