-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode color updates #361
Comments
I believe this is done with #360. But if you have more/further light/dark theme improvements to suggest, let's discuss them here. In general, I noticed with black on white, it's important to have more bold typefaces to make the light colors easier to read on a dark background. |
thanks, it's looking better! i had indicated for the primary Bg to be the darker gray so it got implemented in reverse but it's still better than the light gray it was before. for best legibility the contrast between the background color and text color should be as high as possible. you'll notice when you switch between light and dark mode on websites or apps like Slack, the text weight typically doesn't change, just the colors do. i do agree that we can make other typographic improvements like adjusting font weights across both - light and dark mode. |
Pending tasks
|
Proposing the following edits to improve readability:
Dark Mode
Make background color darker to increase contrast between text and bg
.primaryBg { background: #191919; }
Change nav bar color
.secondaryBg { background: #2E2E2E; }
The text was updated successfully, but these errors were encountered: