Fix for issue #86 - MUI back to top btn added to project #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techy1999 please review this PR, thanks |
techy1999
approved these changes
Apr 30, 2024
| import { Box, Grid, IconButton } from "@mui/material"; | ||
| import Typography from "@mui/material/Typography"; | ||
| import Paper from "@mui/material/Paper"; | ||
| import { FOOTER_MENUS } from '../constants/footer/footer.constants' | ||
| import { FOOTER_MENUS } from "../constants/footer/footer.constants"; |
There was a problem hiding this comment.
Not needed change for your PR. Why you are making it.
Comment on lines
+12
to
+15
| import YouTubeIcon from "@mui/icons-material/YouTube"; | ||
| import FacebookIcon from "@mui/icons-material/Facebook"; | ||
| import InstagramIcon from "@mui/icons-material/Instagram"; | ||
| import LinkedInIcon from "@mui/icons-material/LinkedIn"; |
Comment on lines
+63
to
+67
| <Grid | ||
| container | ||
| spacing={{ xs: 2, md: 4 }} | ||
| columns={{ xs: 4, sm: 8, md: 12 }} | ||
| > |
Comment on lines
+70
to
+76
| <a | ||
| style={{ cursor: "pointer", color: "white" }} | ||
| href={footer_item.URL} | ||
| > | ||
| {" "} | ||
| {footer_item.TEXT}{" "} | ||
| </a> |
Comment on lines
+82
to
+90
| <Box | ||
| style={{ | ||
| marginTop: "30px", | ||
| display: "flex", | ||
| alignItems: "center", | ||
| justifyContent: "center", | ||
| flexDirection: "column", | ||
| }} | ||
| > |
| <IconButton color="white"> | ||
| <FacebookIcon /> | ||
| </IconButton> | ||
| </Box> | ||
| <Typography variant="caption" color="white" textAlign={"center"}> | ||
| Copyright ©{new Date().getFullYear()}. NOMADS.SOLUTIONS | ||
| Copyright ©{new Date().getFullYear()}. NOMADS.SOLUTIONS |
There was a problem hiding this comment.
For now i am approving this PR and merging it.
Suggestion
- check the changes you have made are correct or not before creating any PR. Do not make any unnecessary changes in codebase apart from the feature/bug you are working on. @Sky-De
- Apart from this you PR looks good
Thank you for contributing 💗 , . If you need any help go to discussion Tab and put your question there.
There was a problem hiding this comment.
@techy1999 thanks, but all those changes happened because of prettier, and i mentioned that, also according to issue #88 you will need all those changes on all code source later,
But for now it will be ok, don't worry it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #86
Changes
Fab and NavigationIcon imported from MUI
Added functionality for scrolling to the top as a handler named "backToTopHandler" implemented in the footer component with a new style to be positioned at the top of the footer.
Screenshots
! ! ! ! ISSUE FOUND
I found an issue with mobile responsiveness. Attached is a GIF showing the problem. This issue existed before I added the back-to-top button. You can open an issue related to this and assign that to me, then i will fix it
Consideration
if you have any questions feel free to ask, otherwise let me know you are happy with this PR by merging it,
thanks
skyDe