-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: base64 images not rendered inside of html #671
Conversation
Please try to resolve the conflicts. |
a31832a
to
605d0a1
Compare
@williamdes I rebased. Sorry for the changelog change, but it seems you had an empty space and my IDE wants to remove it :) |
That's okay But can you remove the other commits? |
I'm not sure when this happened, but default base64 encoded images were no longer rendered in html text. If the image is rendered like this: ``` <img src="data:image/png;base64,....." /> ``` the image was not rendered when inside of an html text. Instead one has to replace `data:image/png;base64,` with `@`which in my opinion is not ideal and an overhead. tecnickcom#179 Update include/tcpdf_static.php Co-authored-by: William Desportes <williamdes@wdes.fr>
how about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
Unfortunately the proposed change has security implications as the file_exist function is used in other places too. |
I'm not sure when this happened, but default base64 encoded images were no longer rendered in html text.
If the image is rendered like this:
the image was not rendered when inside of an html text. Instead one has to replace
data:image/png;base64,
with@
which in my opinion is not ideal and an overhead.#179