-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port numbers are required if the port number is not 80/443 #34
Comments
Looks like this is an easy fix:
|
please fix it |
this can be solved on the client side by specifying the host header
|
@meox PRs are open. |
phillipberndt
added a commit
to phillipberndt/requests-aws4auth
that referenced
this issue
Jan 19, 2023
Signatures need to include the host header, but the requests library does not include it in prepared requests by default. Rather, it trusts that Python's HTTP client will compute and inject it when sending the request. This forces requests-aws4auth to compute how this header will look like. A slight discrepancy between the implementations is that the code in this library unconditionally skips the port, whereas the request ending up being sent will include a port if it does not match the URL scheme's default. This change adjusts the implementations to match in that regard. Fixes tedder#34
phillipberndt
added a commit
to phillipberndt/requests-aws4auth
that referenced
this issue
Jan 19, 2023
Signatures need to include the host header, but the requests library does not include it in prepared requests by default. Rather, it trusts that Python's HTTP client will compute and inject it when sending the request. This forces requests-aws4auth to compute how this header will look like. A slight discrepancy between the implementations is that the code in this library unconditionally skips the port, whereas the request ending up being sent will include a port if it does not match the URL scheme's default. This change adjusts the implementations to match in that regard. Fixes tedder#34
phillipberndt
added a commit
to phillipberndt/requests-aws4auth
that referenced
this issue
Jan 20, 2023
Signatures need to include the host header, but the requests library does not include it in prepared requests by default. Rather, it trusts that Python's HTTP client will compute and inject it when sending the request. This forces requests-aws4auth to compute how this header will look like. A slight discrepancy between the implementations is that the code in this library unconditionally skips the port, whereas the request ending up being sent will include a port if it does not match the URL scheme's default. This change adjusts the implementations to match in that regard. Fixes tedder#34
phillipberndt
added a commit
to phillipberndt/requests-aws4auth
that referenced
this issue
Jan 20, 2023
Signatures need to include the host header, but the requests library does not include it in prepared requests by default. Rather, it trusts that Python's HTTP client will compute and inject it when sending the request. This forces requests-aws4auth to compute how this header will look like. A slight discrepancy between the implementations is that the code in this library unconditionally skips the port, whereas the request ending up being sent will include a port if it does not match the URL scheme's default. This change adjusts the implementations to match in that regard. Fixes tedder#34
tedder
pushed a commit
that referenced
this issue
Jan 20, 2023
Signatures need to include the host header, but the requests library does not include it in prepared requests by default. Rather, it trusts that Python's HTTP client will compute and inject it when sending the request. This forces requests-aws4auth to compute how this header will look like. A slight discrepancy between the implementations is that the code in this library unconditionally skips the port, whereas the request ending up being sent will include a port if it does not match the URL scheme's default. This change adjusts the implementations to match in that regard. Fixes #34
phillipberndt
added a commit
to phillipberndt/requests-aws4auth
that referenced
this issue
May 15, 2023
phillipberndt
added a commit
to phillipberndt/requests-aws4auth
that referenced
this issue
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This doesn't work correctly:
It should check to see if the port number is either 80 or 443 and include it if not.
The text was updated successfully, but these errors were encountered: