Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opcache is a problem with the FileSystem driver #135

Merged
merged 4 commits into from
Mar 30, 2014
Merged

Opcache is a problem with the FileSystem driver #135

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c18b33
Switched include() to using eval + file_get_contents instead
CMCDragonkai Mar 15, 2014
31da95f
Instead of eval, we can use invalidate the opcache
CMCDragonkai Mar 26, 2014
88b53c4
Moved opcache_invalidate to storeData instead of getDataFromFile
CMCDragonkai Mar 28, 2014
5ddea80
Updated comment with regards to opcache_invalidate
CMCDragonkai Mar 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/Stash/Driver/FileSystem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ protected static function getDataFromFile($path)
if (!file_exists($path)) {
return false;
}

include($path);

// If the item does not exist we should return false. However, it's
Expand Down Expand Up @@ -217,8 +217,19 @@ public function storeData($key, $data, $expiration)
$storeString .= '/* Type: ' . gettype($data) . ' */' . PHP_EOL;
$storeString .= "\$data = {$dataString};" . PHP_EOL;
}

$result = file_put_contents($path, $storeString, LOCK_EX);

// If opcache is switched on, it will try to cache the PHP data file
// The new php opcode caching system only revalidates against the source files once every few seconds,
// so some changes will not be caught.
// This fix immediately invalidates that opcode cache after a file is written,
// so that future includes are not using the stale opcode cached file.
if (function_exists('opcache_invalidate')) {
opcache_invalidate($path, true);
}

return false !== file_put_contents($path, $storeString, LOCK_EX);
return false !== $result;
}

protected function encode($data)
Expand Down