Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request should use this.parent not this.connection #1338

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

dhensby
Copy link
Collaborator

@dhensby dhensby commented Nov 18, 2021

What this does:

Yikes - I did some debugging related to #1292 and it was clear that the checks we are doing are not very sensible.

  1. Give request.stream and request.arrayRowMode default values of null
  2. Only change the value of the specific request instance's stream or arrayRowMode prop if it's supplied by the parent config.
  3. Replace usage of the non-existent this.connection with this.parent for Request instances 🤦‍♂️

Related issues:

#1292

Pre/Post merge checklist:

  • Update change log

@dhensby dhensby force-pushed the pulls/6/fix-config-inheritance branch 2 times, most recently from 04549be to 65e5b19 Compare November 18, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant