Request should use this.parent not this.connection #1338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
Yikes - I did some debugging related to #1292 and it was clear that the checks we are doing are not very sensible.
request.stream
andrequest.arrayRowMode
default values ofnull
stream
orarrayRowMode
prop if it's supplied by theparent
config.this.connection
withthis.parent
forRequest
instances 🤦♂️Related issues:
#1292
Pre/Post merge checklist: